[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/23] block: Connect BlockBackend to BlockDr
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 03/23] block: Connect BlockBackend to BlockDriverState |
|
Date: |
Mon, 15 Sep 2014 17:34:42 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Benoît Canet <address@hidden> writes:
>> index ff95da6..fa8a7d0 100644
>> --- a/qemu-nbd.c
>> +++ b/qemu-nbd.c
>> @@ -689,7 +689,7 @@ int main(int argc, char **argv)
>> }
>>
>
>> blk = blk_new("hda", &error_abort);
> Is a blk_new_with_bs converssion missing here ?
Yes. Max spotted it, too :)
>> - bs = bdrv_new_root("hda", &error_abort);
>> + bs = blk_bs(blk);
>>
>> srcpath = argv[optind];
>> ret = bdrv_open(&bs, srcpath, NULL, NULL, flags, drv, &local_err);
>> --
>> 1.9.3
>>
- Re: [Qemu-devel] [PATCH v2 02/23] block: New BlockBackend, (continued)
[Qemu-devel] [PATCH v2 08/23] block: Eliminate BlockDriverState member device_name[], Markus Armbruster, 2014/09/13
[Qemu-devel] [PATCH v2 03/23] block: Connect BlockBackend to BlockDriverState, Markus Armbruster, 2014/09/13
[Qemu-devel] [PATCH v2 12/23] virtio-blk: Drop redundant VirtIOBlock member conf, Markus Armbruster, 2014/09/13
[Qemu-devel] [PATCH v2 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf, Markus Armbruster, 2014/09/13
[Qemu-devel] [PATCH v2 01/23] block: Split bdrv_new_root() off bdrv_new(), Markus Armbruster, 2014/09/13
[Qemu-devel] [PATCH v2 06/23] block: Make BlockBackend own its BlockDriverState, Markus Armbruster, 2014/09/13
[Qemu-devel] [PATCH v2 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo(), Markus Armbruster, 2014/09/13