Re: [Qemu-devel] [PATCH 0/5] target-mips: Fix unused-function warnings

[Richard Henderson]

On 09/14/2014 12:45 PM, Peter Maydell wrote:
> These patches fix a number of warnings in target-mips code that
> clang produces; notably, clang will complain about unused
> 'static inline' functions in .c files where gcc does not.
> Some are genuinely totally unused; a few are unused only in some
> configs and so we add ifdef guards.
> 
> (I've actually had these lying around for a while but forgot to
> send them.)
> 
> Peter Maydell (5):
>   target-mips: Remove unused gen_load_ACX, gen_store_ACX and cpu_ACX
>   target-mips/translate.c: Add ifdef guard around check_mips64()
>   target-mips/dsp_helper.c: Add ifdef guards around various functions
>   target-mips/dsp_helper.c: Remove unused function get_DSPControl_24()
>   target-mips/op_helper.c: Remove unused do_lbu() function
> 
>  target-mips/dsp_helper.c | 26 ++++++++++++++++----------
>  target-mips/op_helper.c  |  1 -
>  target-mips/translate.c  | 22 +++-------------------
>  3 files changed, 19 insertions(+), 30 deletions(-)
> 

Reviewed-by: Richard Henderson <address@hidden>


r~