qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt


From: John Snow
Subject: Re: [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt
Date: Mon, 15 Sep 2014 12:31:42 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0



On 09/13/2014 03:50 PM, Paolo Bonzini wrote:
Il 13/09/2014 15:26, Paolo Bonzini ha scritto:

+    if (ad->dp_intr_req) {
+        ahci_trigger_irq(ad->hba, ad, PORT_IRQ_SG_DONE);
+        ad->dp_intr_req = 0;
+    }
Is it also needed in the error case?  Especially the short-PRDT case
that you are adding in the next patch.


... and is it also needed for NCQ, albeit with a separate flag?

Paolo


I had actually thought that it wasn't; due to the more asynchronous nature of NCQ. But... looking back at the specification, I can't find anywhere that explicitly says you can't use these bits for NCQ.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]