Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

[Michael S. Tsirkin]

On Tue, Sep 16, 2014 at 09:28:03AM -0700, Peter Maydell wrote:
> On 16 September 2014 09:23, Paolo Bonzini <address@hidden> wrote:
> > Il 16/09/2014 18:20, Peter Maydell ha scritto:
> >>> > - bumping the minimum required version from 2.12 to 2.16.  I suggest
> >>> > bumping to the currently required version for Windows, which is 2.20
> >>> > (released March 2009).
> >> The commit message for a52d28afb suggests that this bump would be
> >> dropping support for RHEL5. That doesn't seem like a great idea
> >> to me, especially if it's only for the benefit of a test program.
> >
> > Though you would just drop support for "make check" on RHEL5.  Even
> > "make -k check" would roughly work.
> 
> Can't we just put in the makefile and configure magic to skip
> the test if the glib version is too old for it?
> 
> -- PMM

That's exactly what my patch did.
See address@hidden

You prefer that then?