Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

[Gerd Hoffmann]

  Hi,

> Which brings us to the other half of this: what does our
> UI layer specify should be the behaviour for key repeat?
> Gerd, can you clarify what the common input layer's expectation
> is here? Should UI front ends call qemu_input_event_send_key()
> with 'down/down/down/up' or 'down/up/down/up' semantics?

It isn't formally specified anywhere.  The UIs usually simply pass
through the key events they get.  IMO it is more useful to go for
down/down/down/up.  This is how PS/2 works, and this allows the guest to
figure whenever it's autorepeat or really multiple key presses.

cheers,
  Gerd