qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 13/23] virtio-blk: Rename VirtIOBlkConf varia


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf
Date: Thu, 18 Sep 2014 09:17:40 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Benoît Canet <address@hidden> writes:

>> -    if (size % dev->blk.conf.logical_block_size) {
>> +    if (size % dev->conf.conf.logical_block_size) {
>
> This look strange (conf.conf)

Yeah, it does.  I picked conf anyway, for consistency with the existing
similar members of sibling structs VirtIOSCSICommon and VirtIORNG.

> Anyway this seems correct.
>
> Reviewed-by: Benoit Canet <address@hidden>

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]