qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v5 0/1] async: aio_context_new(): Handle event_notif


From: Chrysostomos Nanakos
Subject: [Qemu-devel] [PATCH v5 0/1] async: aio_context_new(): Handle event_notifier_init failure
Date: Thu, 18 Sep 2014 14:30:48 +0300

v4->v5
------
* Set thread_id before calling aio_context_new(). That way qmp_query_iothreads()
  will display thread_id -1 for a failed IOThread object than an uninitialized
  value.
* qemu_init_main_loop() will return -EMFILE if aio_context_new() fail. The
  actual failure reason is placed in the propagated error message.
* Initialize 'Error *local_error' value to NULL.

v3->v4
------
* Remove escaped single quotes from error messages.
* Rephrase commit log.

v2->v3
------
* Remove errno usage and print the detailed message based on errno when
  event_notifier_init() fails.
* Propagate error and return from iothread_complete() if aio_context_new() 
fails.
* Return if !iothread->ctx from iothread_instance_finalize(), used by QOM
  when object_unref(obj) is called after user_creatable_complete() fails.
* Remove cosmetic fixes accidentally introduced by editor and fix code style
  issues.

v1->v2
------
* aio_context_new() returns NULL if the initialization of event notifier fails.
* Add descriptive error messages if aio_context_new() and event_notifier_init()
  fail.
* Fix gpollfds leak.


Chrysostomos Nanakos (1):
  async: aio_context_new(): Handle event_notifier_init failure

 async.c                  |   16 +++++++++++-----
 include/block/aio.h      |    2 +-
 include/qemu/main-loop.h |    2 +-
 iothread.c               |   11 ++++++++++-
 main-loop.c              |    9 +++++++--
 qemu-img.c               |    8 +++++++-
 qemu-io.c                |    7 ++++++-
 qemu-nbd.c               |    6 +++++-
 tests/test-aio.c         |   10 +++++++++-
 tests/test-thread-pool.c |   10 +++++++++-
 tests/test-throttle.c    |   10 +++++++++-
 vl.c                     |    5 +++--
 12 files changed, 78 insertions(+), 18 deletions(-)

-- 
1.7.10.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]