[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize |
Date: |
Thu, 18 Sep 2014 14:58:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 18/09/2014 14:47, address@hidden ha scritto:
> From: Gonglei <address@hidden>
>
> DeviceClass->init is the old interface, let's convert usb
> devices to the new realize API. In this way, all the
> implementations now use error_setg instead of
> qerror_report/error_report for reporting error.
>
> Cc: Markus Armbruster <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
>
> v2 -> v1:
> - fix PATCH 2, using qerror_report_err print error messages
> when attach fails (Paolo)
> - using errp instead of qerror_report_err introduced by
> fix 1 in PATCH 12 (Paolo)
> - fix missing return in PATCH 14 (Paolo)
> - add 'Reviewed-by' tag for other patches
>
> Thanks a lot for reviewing!
>
>
> Gonglei (19):
> usb-storage: fix possible memory leak and missing error message
> usb-bus: convert USBDeviceClass init to realize
> usb-net: convert init to realize
> libusb: convert init to realize
> libusb: using error_report instead of fprintf
> usb-hub: convert init to realize
> dev-storage: convert init to realize
> dev-storage: usring error_report instead of fprintf/printf
> dev-uas: convert init to realize
> dev-uas: using error_report instead of fprintf
> dev-bluetooth: convert init to realize
> dev-serial: convert init to realize
> usb-ccid: convert init to realize
> dev-hid: convert init to realize
> dev-wacom: convert init to realize
> usb-audio: convert init to realize
> usb-redir: convert init to realize
> usb-mtp: convert init to realize
> usb-bus: remove "init" from USBDeviceClass struct
>
> hw/usb/bus.c | 79
> ++++++++++++++++++++++---------------------
> hw/usb/dev-audio.c | 5 ++-
> hw/usb/dev-bluetooth.c | 6 ++--
> hw/usb/dev-hid.c | 27 +++++++--------
> hw/usb/dev-hub.c | 9 +++--
> hw/usb/dev-mtp.c | 5 ++-
> hw/usb/dev-network.c | 9 +++--
> hw/usb/dev-serial.c | 22 +++++++-----
> hw/usb/dev-smartcard-reader.c | 5 ++-
> hw/usb/dev-storage.c | 42 ++++++++++++-----------
> hw/usb/dev-uas.c | 17 +++++-----
> hw/usb/dev-wacom.c | 5 ++-
> hw/usb/host-libusb.c | 33 +++++++++---------
> hw/usb/redirect.c | 21 +++++++-----
> include/hw/usb.h | 10 ++++--
> 15 files changed, 150 insertions(+), 145 deletions(-)
>
Looks good, thanks!
Paolo
- [Qemu-devel] [PATCH v2 13/19] usb-ccid: convert init to realize, (continued)
- [Qemu-devel] [PATCH v2 13/19] usb-ccid: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 05/19] libusb: using error_report instead of fprintf, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 15/19] dev-wacom: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 14/19] dev-hid: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 16/19] usb-audio: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 19/19] usb-bus: remove "init" from USBDeviceClass struct, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 18/19] usb-mtp: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 17/19] usb-redir: convert init to realize, arei.gonglei, 2014/09/18
- Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize, Markus Armbruster, 2014/09/18
- Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize, Gerd Hoffmann, 2014/09/19