[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/14] ppc: introduce ppc_get_crf and ppc_set_cr
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 09/14] ppc: introduce ppc_get_crf and ppc_set_crf |
Date: |
Fri, 19 Sep 2014 16:52:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 18/09/2014 21:51, Tom Musta ha scritto:
>
> Checkpatch fails:
> WARNING: braces {} are necessary for all arms of this statement
> #171: FILE: target-ppc/translate.c:11111:
> + if (ppc_get_crf(env, i) & 0x08)
> [...]
> - else if (env->crf[i] & 0x04)
> [...]
> a = 'G';
> [...]
>
> WARNING: braces {} are necessary for all arms of this statement
> #174: FILE: target-ppc/translate.c:11113:
> + else if (ppc_get_crf(env, i) & 0x04)
> [...]
> - else if (env->crf[i] & 0x02)
> [...]
>
> WARNING: braces {} are necessary for all arms of this statement
> #177: FILE: target-ppc/translate.c:11115:
> + else if (ppc_get_crf(env, i) & 0x02)
> [...]
>
> total: 0 errors, 3 warnings, 131 lines checked
>
This goes away with patch 14, so I made the intermediate patch lighter
by omitting the code-style cleanups.
Paolo
- Re: [Qemu-devel] [PATCH 06/14] ppc: introduce helpers for mfocrf/mtocrf, (continued)
- [Qemu-devel] [PATCH 07/14] ppc: reorganize gen_compute_fprf, Paolo Bonzini, 2014/09/15
- [Qemu-devel] [PATCH 08/14] ppc: introduce gen_op_mfcr/gen_op_mtcr, Paolo Bonzini, 2014/09/15
- [Qemu-devel] [PATCH 09/14] ppc: introduce ppc_get_crf and ppc_set_crf, Paolo Bonzini, 2014/09/15
- [Qemu-devel] [PATCH 10/14] ppc: use movcond for isel, Paolo Bonzini, 2014/09/15
- [Qemu-devel] [PATCH 11/14] ppc: store CR registers in 32 1-bit registers, Paolo Bonzini, 2014/09/15
- [Qemu-devel] [PATCH 12/14] ppc: use movcond to implement evsel, Paolo Bonzini, 2014/09/15
- [Qemu-devel] [PATCH 13/14] ppc: inline ppc_set_crf when clearer, Paolo Bonzini, 2014/09/15
- [Qemu-devel] [PATCH 14/14] ppc: dump all 32 CR bits, Paolo Bonzini, 2014/09/15