qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 10/23] block: Eliminate DriveInfo member bdrv


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v3 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()
Date: Sat, 20 Sep 2014 23:09:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1

On 16.09.2014 20:12, Markus Armbruster wrote:
The patch is big, but all it really does is replacing

     dinfo->bdrv

by

     blk_bs(blk_by_legacy_dinfo(dinfo))

The replacement is repetitive, but the conversion of device models to
BlockBackend is imminent, and will shorten it to just
blk_legacy_dinfo(dinfo).

Line wrapping muddies the waters a bit.  I also omit tests whether
dinfo->bdrv is null, because it never is.

Signed-off-by: Markus Armbruster <address@hidden>
---
  blockdev.c                               |  3 +--
  hw/arm/collie.c                          |  9 +++++----
  hw/arm/gumstix.c                         |  5 +++--
  hw/arm/mainstone.c                       |  8 ++++----
  hw/arm/musicpal.c                        | 11 ++++++-----
  hw/arm/nseries.c                         |  6 ++++--
  hw/arm/omap1.c                           |  4 +++-
  hw/arm/omap2.c                           |  4 +++-
  hw/arm/omap_sx1.c                        |  9 +++++----
  hw/arm/pxa2xx.c                          |  7 +++++--
  hw/arm/spitz.c                           |  4 +++-
  hw/arm/versatilepb.c                     |  4 +++-
  hw/arm/vexpress.c                        |  4 +++-
  hw/arm/virt.c                            |  4 +++-
  hw/arm/xilinx_zynq.c                     |  4 +++-
  hw/arm/z2.c                              |  7 ++++---
  hw/block/fdc.c                           | 16 +++++++++++-----
  hw/block/m25p80.c                        |  5 +++--
  hw/block/xen_disk.c                      |  2 +-
  hw/cris/axis_dev88.c                     |  3 ++-
  hw/display/tc6393xb.c                    |  4 +++-
  hw/i386/pc_sysfw.c                       |  3 ++-
  hw/ide/piix.c                            |  6 ++++--
  hw/ide/qdev.c                            |  4 +++-
  hw/isa/pc87312.c                         |  7 +++++--
  hw/lm32/lm32_boards.c                    | 13 +++++++------
  hw/lm32/milkymist.c                      |  7 ++++---
  hw/microblaze/petalogix_ml605_mmu.c      |  5 +++--
  hw/microblaze/petalogix_s3adsp1800_mmu.c |  5 +++--
  hw/mips/mips_malta.c                     |  4 +++-
  hw/mips/mips_r4k.c                       |  5 +++--
  hw/pci/pci-hotplug-old.c                 |  9 ++++++---
  hw/ppc/ppc405_boards.c                   | 25 ++++++++++++++++---------
  hw/ppc/spapr.c                           |  4 +++-
  hw/ppc/virtex_ml507.c                    |  5 +++--
  hw/scsi/scsi-bus.c                       |  5 +++--
  hw/sd/milkymist-memcard.c                |  7 +++++--
  hw/sd/pl181.c                            |  3 ++-
  hw/sd/sdhci.c                            |  3 ++-
  hw/sd/ssi-sd.c                           |  3 ++-
  hw/sh4/r2d.c                             |  5 +++--
  hw/usb/dev-storage.c                     |  4 +++-
  hw/xtensa/xtfpga.c                       |  4 +++-
  include/sysemu/blockdev.h                |  1 -
  44 files changed, 166 insertions(+), 94 deletions(-)

Reviewed-by: Max Reitz <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]