Re: [Qemu-devel] [PATCH v3 4/4] ivshmem: Fix fd leak on error

[Michael S. Tsirkin]

On Mon, Sep 15, 2014 at 06:40:08PM +0200, Andreas Färber wrote:
> Reported-by: Stefan Hajnoczi <address@hidden>
> Cc: address@hidden
> Signed-off-by: Andreas Färber <address@hidden>

Reviewed-by: Michael S. Tsirkin <address@hidden>

> ---
>  hw/misc/ivshmem.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index ecef82a..bf585b7 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -512,6 +512,7 @@ static void ivshmem_read(void *opaque, const uint8_t 
> *buf, int size)
>      if (incoming_fd == -1) {
>          fprintf(stderr, "could not allocate file descriptor %s\n",
>                                                              strerror(errno));
> +        close(tmp_fd);
>          return;
>      }
>  
> -- 
> 1.8.4.5