Re: [Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected

[Paolo Bonzini]

Il 22/09/2014 15:30, Corey Minyard ha scritto:
>>> >> I had to make this change, otherwise a server socket would never show
>>> >> that it reconnected.  I originally hadn't moved it.
>> > Reconnected or connected?  How does reconnection work with server
>> > sockets?  I guess you can then move it to patch 2.
> When a server socket disconnects, it runs through the disconnect code so it
> shows "disconnected".  It does not call
> qemu_chr_finish_socket_connection when
> it reconnects, though, so it would never show the new connection.

Ah, I see now what you mean.  Of course for a server socket it's
reconnection from a different client; it's not related to the new
functionality.

> I can move it to patch 2, but it seems more logical to me here, since it
> doesn't really
> matter until this patch.

Yes, that's fine.

Reviewed-by: Paolo Bonzini <address@hidden>