[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] trace: drop orphan events from ./trace-even
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] trace: drop orphan events from ./trace-events |
Date: |
Mon, 22 Sep 2014 17:45:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Stefan Hajnoczi <address@hidden> writes:
> Over time a few unused trace events have been left behind in ./trace-events.
> Either the code that called them was deleted or the event was never called in
> the first place.
>
> This is a clear violation of the solider's motto "no man left behind". It's
> time to bring these trace events home.
>
> On a more serious note, unused trace events cause confusion to users who want
> to enable existing instrumentation. On the SystemTap backend we get errors
> when attempting to enable them because the static probes that these events are
> based on do not exist.
Reviewed-by: Markus Armbruster <address@hidden>
While you're at it, could you also clean up the pointers to source files
that have bit-rotted?
$ scripts/cleanup-trace-events.pl trace-events | diff -u trace-events -
--- trace-events 2014-09-22 17:40:04.228700732 +0200
+++ - 2014-09-22 17:41:03.107310697 +0200
@@ -836,7 +836,7 @@
pvscsi_tx_rings_ppn(const char* label, uint64_t ppn) "%s page: %"PRIx64""
pvscsi_tx_rings_num_pages(const char* label, uint32_t num) "Number of %s
pages: %u"
-# xen-all.c
+# xen-hvm.c
xen_ram_alloc(unsigned long ram_addr, unsigned long size) "requested: %#lx,
size %#lx"
xen_client_set_memory(uint64_t start_addr, unsigned long size, bool log_dirty)
"%#"PRIx64" size %#lx, log_dirty %i"
@@ -845,7 +845,7 @@
xen_remap_bucket(uint64_t index) "index %#"PRIx64
xen_map_cache_return(void* ptr) "%p"
-# hw/xen/xen_platform.c
+# hw/i386/xen/xen_platform.c
xen_platform_log(char *s) "xen platform: %s"
# qemu-coroutine.c
@@ -1075,6 +1075,7 @@
vmware_scratch_write(uint32_t index, uint32_t value) "index %d, value 0x%x"
vmware_setmode(uint32_t w, uint32_t h, uint32_t bpp) "%dx%d @ %d bpp"
+# vmstate.c
# savevm.c
savevm_section_start(const char *id, unsigned int section_id) "%s, section_id
%u"
savevm_section_end(const char *id, unsigned int section_id) "%s, section_id %u"
@@ -1241,7 +1242,7 @@
virtio_ccw_interpret_ccw(int cssid, int ssid, int schid, int cmd_code)
"VIRTIO-CCW: %x.%x.%04x: interpret command %x"
virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char
*devno_mode) "VIRTIO-CCW: add subchannel %x.%x.%04x, devno %04x (%s)"
-# hw/intc/s390_flic.c
+# hw/intc/s390_flic_kvm.c
flic_create_device(int err) "flic: create device failed %d"
flic_no_device_api(int err) "flic: no Device Contral API support %d"
flic_reset_failed(int err) "flic: reset failed %d"
@@ -1254,6 +1255,7 @@
migrate_pending(uint64_t size, uint64_t max) "pending size %" PRIu64 " max %"
PRIu64
migrate_transferred(uint64_t tranferred, uint64_t time_spent, double
bandwidth, uint64_t size) "transferred %" PRIu64 " time_spent %" PRIu64 "
bandwidth %g max_size %" PRId64
+# target-ppc/kvm.c
# kvm-all.c
kvm_ioctl(int type, void *arg) "type 0x%x, arg %p"
kvm_vm_ioctl(int type, void *arg) "type 0x%x, arg %p"
@@ -1282,10 +1284,12 @@
object_dynamic_cast_assert(const char *type, const char *target, const char
*file, int line, const char *func) "%s->%s (%s:%d:%s)"
object_class_dynamic_cast_assert(const char *type, const char *target, const
char *file, int line, const char *func) "%s->%s (%s:%d:%s)"
-# hw/xen/xen_pvdevice.c
+# hw/i386/xen/xen_pvdevice.c
xen_pv_mmio_read(uint64_t addr) "WARNING: read from Xen PV Device MMIO space
(address %"PRIx64")"
xen_pv_mmio_write(uint64_t addr) "WARNING: write to Xen PV Device MMIO space
(address %"PRIx64")"
+# hw/i386/pc.c
+# hw/acpi/memory_hotplug.c
# hw/pci/pci_host.c
pci_cfg_read(const char *dev, unsigned devid, unsigned fnid, unsigned offs,
unsigned val) "%s %02u:%u @0x%x -> 0x%x"
pci_cfg_write(const char *dev, unsigned devid, unsigned fnid, unsigned offs,
unsigned val) "%s %02u:%u @0x%x <- 0x%x"