[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] vfio: migration to trace points
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC] vfio: migration to trace points |
Date: |
Mon, 22 Sep 2014 17:15:52 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Sep 19, 2014 at 06:07:02PM +0200, Eric Auger wrote:
> Also as I mentionned in the commit message, I identified some parsing
> issues that forced me to change few format strings. I don't know if you
> have time or are willing to fix those - you may be more efficient doing
> those fixes than I would;-) - Nethertheless if you can't afford, I will
> have a look at the Python code.
>
> For convenience I put the issues again, all related to parenthesis:
>
> Cases than are not correctly handled are given below:
> - "(%04x:%02x:%02x.%x)" need to be replaced by " (%04x:%02x:%02x.%x)"
> - "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d) = 0x%"PRIx64 replaced by
> "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d = 0x%"PRIx64
> - "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d)"
> replaced by
> "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d"
Thanks for pointing this out. I have sent a fix:
[PATCH] trace: tighten up trace-events regex to fix bad parse
Please let me know if it solves the issues for you.
Stefan
pgpkL028fL_li.pgp
Description: PGP signature