[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qtest: fix qtest log fd should be initialized b
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] qtest: fix qtest log fd should be initialized before qtest chardev |
|
Date: |
Mon, 22 Sep 2014 17:21:16 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Sep 03, 2014 at 05:52:06PM +0800, john.liuli wrote:
> From: Li Liu <address@hidden>
>
> qtest_log_fp should be inited before qemu_chr_add_handlers.
> If not the log dumped from callback functions may be lost.
>
> easy to reproduce it by command:
> "QTEST_LOG=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64
> gtester -k --verbose -m=quick tests/qdev-monitor-test"
>
> The log "[I xxxxxx] OPENED" should be printed out by
> qtest_event, but does not.
>
> Signed-off-by: Li Liu <address@hidden>
> ---
> qtest.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpkW2ljHrOUw.pgp
Description: PGP signature