[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client socke
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets |
Date: |
Mon, 22 Sep 2014 14:26:34 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 09/22/2014 10:59 AM, address@hidden wrote:
> From: Corey Minyard <address@hidden>
>
> Adds a "reconnect" option to socket backends that gives a reconnect
> timeout. This only applies to client sockets. If the other end
> of a socket closes the connection, qemu will attempt to reconnect
> after the given number of seconds.
>
> Signed-off-by: Corey Minyard <address@hidden>
> ---
> qapi-schema.json | 14 +++++----
> qemu-char.c | 88
> ++++++++++++++++++++++++++++++++++++++++++++++++++++----
> qemu-options.hx | 20 ++++++++-----
> 3 files changed, 104 insertions(+), 18 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 689b548..79f7a07 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -2648,14 +2648,18 @@
> # @nodelay: #optional set TCP_NODELAY socket option (default: false)
> # @telnet: #optional enable telnet protocol on server
> # sockets (default: false)
> +# @reconnect: #optional If not a server socket, if the socket disconnect
> +# then reconnect after the given number of seconds. Setting
> +# to zero disables this function. (default: 0). Since: 2.2.
Looks like I reviewed v1 after you had posted v2; my comments still
apply about this being awkward wording.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/6] chardev: Add reconnecting to client sockets, minyard, 2014/09/22
- [Qemu-devel] [PATCH 2/6] qemu-char: Rework qemu_chr_open_socket() for reconnect, minyard, 2014/09/22
- [Qemu-devel] [PATCH 3/6] qemu-char: Move some items into TCPCharDriver, minyard, 2014/09/22
- [Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected, minyard, 2014/09/22
- [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets, minyard, 2014/09/22
- Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets,
Eric Blake <=
- [Qemu-devel] [PATCH 6/6] qemu-char: Print the remote and local addresses for a socket, minyard, 2014/09/22
- [Qemu-devel] [PATCH 1/6] qemu-char: Make the filename size for a chardev a #define, minyard, 2014/09/22