Re: [Qemu-devel] [PATCH] qemu-log: add log category for MIPS MMU fault info

[Peter Maydell]

On 23 September 2014 10:04, Antony Pavlov <address@hidden> wrote:
> Running barebox on qemu-system-mips* with '-d unimp' overloads
> stderr by very very many mips_cpu_handle_mmu_fault() messages:
>
>   mips_cpu_handle_mmu_fault address=b80003fd ret 0 physical 00000000180003fd 
> prot 3
>   mips_cpu_handle_mmu_fault address=a0800884 ret 0 physical 0000000000800884 
> prot 3
>   mips_cpu_handle_mmu_fault pc a080cd80 ad b80003fd rw 0 mmu_idx 0
>
> So it's very difficult to find LOG_UNIMP message.
>
> The mips_cpu_handle_mmu_fault() messages appears on enabling ANY
> logging! It's not very handy.
>
> Adding separate log category for mips_cpu_handle_mmu_fault()
> logging fixes the problem.

I don't think we should have CPU-specific logging categories
(the x86-only categories are somewhat legacy). Can you
make this a category that applies to all CPU architectures
rather than a MIPS specific one, please? Given most of them
have an MMU I think that just means removing the "mips
only" text from the help documentation...

thanks
-- PMM