Re: [Qemu-devel] [PATCH 0/2] usb-serial: only check speed once at realize time

[Gonglei (Arei)]

And this one :)  Thanks!


Best regards,
-Gonglei


> -----Original Message-----
> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo
> Bonzini
> Sent: Friday, September 19, 2014 4:08 PM
> To: Gonglei (Arei); address@hidden
> Cc: Huangweidong (C); Luonengjun; Huangpeng (Peter); address@hidden;
> address@hidden
> Subject: Re: [PATCH 0/2] usb-serial: only check speed once at realize time
> 
> Il 19/09/2014 09:25, address@hidden ha scritto:
> > From: Gonglei <address@hidden>
> >
> > This patch series based on
> >  [PATCH v3 00/19] usb: convert device init to realize
> >
> > As Paolo's comments:
> >
> > usb port speed check could be extracted to a separate
> > function usb_check_attach, that is called just once at realize time,
> > even if !s->cs->be_open.
> >
> > Please review, Thanks. :)
> >
> > Gonglei (2):
> >   usb-bus: introduce a wrapper function to check speed
> >   usb-serial: only check speed once at realize time
> >
> >  hw/usb/bus.c        | 14 +++++++++++++-
> >  hw/usb/dev-serial.c | 16 +++++++++-------
> >  include/hw/usb.h    |  1 +
> >  3 files changed, 23 insertions(+), 8 deletions(-)
> >
> 
> Reviewed-by: Paolo Bonzini <address@hidden>