Re: [Qemu-devel] [PATCH v2 0/2] list supported machine types in well-defined order

[David Gibson]

On Mon, Sep 22, 2014 at 10:38:34PM +0200, Laszlo Ersek wrote:
> The first patch introduces a generic comparator. This comparator should
> cover all machine types at once that don't belong to machine type
> "families". Hence, for example, the output it produces for
> 
>   qemu-system-aarch64 -M \?
> 
> is meant to be final. (See examples in the patches.)
> 
> The second patch files piix and q35 machine types into their respective
> families.
> 
> Paolo said we needed to care about "pseries, pc, q35", but I got no clue
> about "pseries", so I didn't touch that. It shouldn't be hard for
> someone who knows "pseries" to post a followup patch that covers it.
> Until then, "pseries" machine types are listed in alphabetical order (no
> families).

Acked-by: David Gibson <address@hidden>

pseries is fairly simple; there are two pseries machine types, plain
"pseries" and "pseries-2.1".  These should both be in the same family.

Implementation needs to be a little different than for PC, because the
pseries machines are fully QOM-ized so there are no QEMUMachine
structures any more.  We'll need to set family from the *_class_init()
functions instead.

This is then complicated a little, because there's a pending patch in
agraf's tree which re-organizes the pseries machine types a ltitle.
After that there are still two pseries machine types, "pseries-2.1"
and "pseries-2.2" (aliased to "pseries").  Again, both should be in
the "pseries" family.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgpMmvYYUoYjP.pgp
Description: PGP signature