[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 27/30] usb-storage: drop not needed "allow_hotplug =
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH 27/30] usb-storage: drop not needed "allow_hotplug = 0" |
Date: |
Wed, 24 Sep 2014 11:48:16 +0000 |
Drop useless hack that disables hotplug on bus, after backend
storage was added to it, by setting "allow_hotplug = 0". Even
if bus is hotpluggable, It won't be possible to add another
SCSI device to bus since its realize will fail early with
error "no free target" in scsi_qdev_realize() method.
Signed-off-by: Igor Mammedov <address@hidden>
---
hw/usb/dev-storage.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index 4ad4ec7..b168d7c 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -632,7 +632,6 @@ static void usb_msd_realize_storage(USBDevice *dev, Error
**errp)
error_propagate(errp, err);
return;
}
- s->bus.qbus.allow_hotplug = 0;
usb_msd_handle_reset(dev);
if (bdrv_key_required(bs)) {
--
1.8.3.1
- [Qemu-devel] [PATCH 26/30] usb-storage: make its storage SCSI bus hotpluggable explicitly, (continued)
- [Qemu-devel] [PATCH 30/30] qdev: HotplugHandler: add support for unplugging BUS-less devices, Igor Mammedov, 2014/09/24
- [Qemu-devel] [PATCH 16/30] virtio-serial: convert to hotplug-handler API, Igor Mammedov, 2014/09/24
- [Qemu-devel] [PATCH 27/30] usb-storage: drop not needed "allow_hotplug = 0",
Igor Mammedov <=
- [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API, Igor Mammedov, 2014/09/24
- Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API, Gerd Hoffmann, 2014/09/24
- Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API, Paolo Bonzini, 2014/09/24
- Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API, Gerd Hoffmann, 2014/09/24
- Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API, Igor Mammedov, 2014/09/24
- Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API, Gerd Hoffmann, 2014/09/25
- Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API, Igor Mammedov, 2014/09/25
- Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API, Paolo Bonzini, 2014/09/25
- Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API, Igor Mammedov, 2014/09/25