Re: [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0"

[Paolo Bonzini]

Il 24/09/2014 13:48, Igor Mammedov ha scritto:
> usb-bot creates SCSI bus and immediately makes it
> non hotpluggable which makes not possible to add
> anything to it after machine is created.
> 
> Taking in account that ubs-bot doesn't implement
> HOTPLUG_HANDLER interface, SCSI will be created as
> non hotpluggable, so there is not need to reset
> allow_hotplug field anymore.
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  hw/usb/dev-storage.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
> index bd7cc53..bfa71c7 100644
> --- a/hw/usb/dev-storage.c
> +++ b/hw/usb/dev-storage.c
> @@ -653,7 +653,6 @@ static void usb_msd_realize_bot(USBDevice *dev, Error 
> **errp)
>      usb_desc_init(dev);
>      scsi_bus_new(&s->bus, sizeof(s->bus), DEVICE(dev),
>                   &usb_msd_scsi_info_bot, NULL);
> -    s->bus.qbus.allow_hotplug = 0;
>      usb_msd_handle_reset(dev);
>  }
>  
> 

I guess the fate of this patch depends on the answer to the previous
questions.

The usb-bot hotplug handler should return an error on both plug and
unplug.  You will decide whether to do it explicitly, or in
hw/core/hotplug.c with NULL callbacks in usb-bot.

Paolo