Re: [Qemu-devel] [PATCH v4 0/2] trace: Trace control commands

[Stefan Hajnoczi]

On Mon, Aug 25, 2014 at 01:19:51PM +0200, Lluís Vilanova wrote:
> Adds QAPI/QMP commands to control tracing events, and reimplements some of the
> related HMP commands on top.
> 
> NOTE: The "trace-event-set-state" command uses a bool 'enable' argument 
> instead
>       of an enum 'state'. I'm still not sure if an enum is better than the two
>       separate booleans.
> 
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> 
> Changes in v4:
> 
> * Split QAPI/QMP and HMP changes into separate patches.
> * Add copyright information in QAPI file (Eric Blake).
> * Replace event state booleans with an enum (Eric Blake).
> * Document pattern type for argument "name" (Eric Blake).
> * Other documentation improvements (Markus Armbruster).
> * Change "keepgoing" to "ignore-unavailable" (Markus Armbruster).
> * Add examples in QMP command definition file (Eric Blake).
> * Propagate QMP errors to HMP (Markus Armbruster, Stefan Hajnoczi).
> * Remove trailing newlines when using error_setg (Stefan Hajnoczi).
> * Avoid multiple invocations of error_setg (Stefan Hajnoczi).
> * Various cosmetic changes (Markus Armbruster).

Sorry for the long wait.  I am merging it now.

The only thing I wonder about is adding trace/qmp.o to util-obj-y.  But
I've built QEMU from scratch also for Windows and the build completes
successfully.  I was worried that a utility like qemu-img might not have
the necessary headers or objects for QMP code but it seems to work.

If there are issues we can still fix it later in the 2.2 release cycle.

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

pgpNTq9zsoizn.pgp
Description: PGP signature