Re: [Qemu-devel] [PATCH 21/30] scsi: make scsi_bus_new() assign hotplug controller

[Igor Mammedov]

On Wed, 24 Sep 2014 14:14:48 +0200
Paolo Bonzini <address@hidden> wrote:

> Il 24/09/2014 13:48, Igor Mammedov ha scritto:
> > it will allow incrementally convert every controller that
> > creates SCSI bus and supports hotplug to hotplug controller API
> > 
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> >  hw/scsi/scsi-bus.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
> > index 954c607..33495b6 100644
> > --- a/hw/scsi/scsi-bus.c
> > +++ b/hw/scsi/scsi-bus.c
> > @@ -92,7 +92,7 @@ void scsi_bus_new(SCSIBus *bus, size_t bus_size, 
> > DeviceState *host,
> >      qbus_create_inplace(bus, bus_size, TYPE_SCSI_BUS, host, bus_name);
> >      bus->busnr = next_scsi_bus++;
> >      bus->info = info;
> > -    bus->qbus.allow_hotplug = 1;
> > +    qbus_set_hotplug_handler(BUS(bus), host, &error_abort);
> >  }
> >  
> >  static void scsi_dma_restart_bh(void *opaque)
> > 
> 
> Hmm, what if the host is not a HotplugHandler?  Then you should just do
> nothing for plug, and object_unparent for unplug.  Is that broken by
> this patch?
It will break with 24/30. I'll respin with all not yet converted
HBAs implementing  HotplugHandler interface with simple unplug callback.

> 
> Paolo
>