Re: [Qemu-devel] [PATCH v3] docs: add blkdebug block driver documentation

[John Snow]

On 09/24/2014 12:24 PM, Max Reitz wrote:
> On 24.09.2014 11:44, Stefan Hajnoczi wrote:
> > The blkdebug block driver is undocumented.  Documenting it is worthwhile
> > since it offers powerful error injection features that are used by
> > qemu-iotests test cases.
> >
> > This document will make it easier for people to learn about and use
> > blkdebug.
> >
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > ---
> > v3:
> >   * Fix tab space damage [Eric]
> >   * Rephrase event_names[] as full list of events [Eric]
> >   * Explain that blkdebug state is not observable from outside [Eric]
> >   * Clarify state 0 and state 1 [Eric]
> >
> > v2:
> >   * Added GPL v2 or later license and Red Hat copyright [Eric]
> >   * Expanded ini rules file explanation [Paolo]
> >   * Added note that errno values depend on the host [Eric]
> >
> >   docs/blkdebug.txt | 161
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 161 insertions(+)
> >   create mode 100644 docs/blkdebug.txt
>
> Reviewed-by: Max Reitz <address@hidden>
>
> Maybe I'll add information about blkdebug's QMP interface sometime...

If you have the cycles and the knowledge, you definitely should!