Re: [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0"

[Gerd Hoffmann]

  Hi,

> But there is room for improvement here,
> it it's possible to error out even earlier if usb-bot would be marked
> as not hotpluggable device and add to qdev_device_add() check if
> device is hotpluggable even before it's created.

usb-bot not being hot-pluggable is a consequence of the fact that we can
only hotplug single devices in qemu today.  usb-bot without scsi devices
hooked up is useless.  Plugging in usb-bot first and plugging in disks
later doesn't work (well, could sort-of work when you plug them fast,
but you are racing with the guest initializing the device then).  With
some way to first compose the whole thing (usb-bot + disks), then
plug-in as whole usb-bot hotplugging would work though.

cheers,
  Gerd