[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] block: Validate node-name
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] block: Validate node-name |
|
Date: |
Thu, 25 Sep 2014 15:25:05 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 25.09.2014 um 09:54 hat Kevin Wolf geschrieben:
> The device_name of a BlockDriverState is currently checked because it is
> always used as a QemuOpts ID and qemu_opts_create() checks whether such
> IDs are wellformed.
>
> node-name is supposed to share the same namespace, but it isn't checked
> currently. This patch adds explicit checks both for device_name and
> node-name so that the same rules will still apply even if QemuOpts won't
> be used any more at some point.
>
> qemu-img used to use names with spaces in them, which isn't allowed any
> more. Replace them with underscores.
>
> Signed-off-by: Kevin Wolf <address@hidden>
Applied to the block branch.
Kevin