qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 07/10] target-arm: A64: Emulate the HVC insn


From: Edgar E. Iglesias
Subject: Re: [Qemu-devel] [PATCH v6 07/10] target-arm: A64: Emulate the HVC insn
Date: Fri, 26 Sep 2014 09:06:08 +1000
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Sep 26, 2014 at 12:01:11AM +0100, Peter Maydell wrote:
> On 25 September 2014 23:20, Edgar E. Iglesias <address@hidden> wrote:
> > On Thu, Sep 25, 2014 at 07:39:32PM +0100, Peter Maydell wrote:
> >> HCR.TGE isn't actually relevant for some exceptions
> >> (eg SMC), and the HVC handling you have below
> >> effectively ends up ignoring the route_to_el2
> >> information. That suggests to me that you should put
> >> this code in a default: case in the switch below.
> >
> > I don't really test nor support TGE so I'll just drop the TGE part.
> 
> I'd rather we just implemented it properly...

IMO, It's not about implementing it properly. It's about implementing the
EL3/2 support incrementally. The spec is too big to add all the features
at once.

Cheers,
Edgar



reply via email to

[Prev in Thread] Current Thread [Next in Thread]