qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 3/3] s390x/css: catch ccw sequence errors


From: Christian Borntraeger
Subject: Re: [Qemu-devel] [PULL 3/3] s390x/css: catch ccw sequence errors
Date: Fri, 26 Sep 2014 12:49:06 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0

On 09/26/2014 12:36 PM, Andreas Färber wrote:

>> @@ -1414,6 +1423,7 @@ int subch_device_load(SubchDev *s, QEMUFile *f)
>>          s->id.ciw[i].count = qemu_get_be16(f);
>>      }
>>      s->ccw_fmt_1 = qemu_get_byte(f);
>> +    s->ccw_no_data_cnt = qemu_get_byte(f);
>>      return 0;
>>  }
>>  
> 
> You need to bump the version saved if you add fields (same as VMState),
> and on load you need to check the version for whether to load the field
> (or deny loading).

Alex brough up the same thing. As the cpu migration code is not yet upstream 
(in prep right now) we concluded that this is still ok.

http://lists.gnu.org/archive/html/qemu-devel/2014-09/msg01094.html




reply via email to

[Prev in Thread] Current Thread [Next in Thread]