qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 23/36] s390x: drop not used allow_hotplug in


From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH v2 23/36] s390x: drop not used allow_hotplug in event-facility
Date: Fri, 26 Sep 2014 12:52:36 +0200

On Fri, 26 Sep 2014 09:28:28 +0000
Igor Mammedov <address@hidden> wrote:

> s390-sclp-event-facility creates s390-sclp-events-bus
> and immeadiatly sets its allow_hotplug field to 0,
> which is NOP since it's already 0 by default.
> 
> Also since BUS is not hotpluggable, it's not possible
> to call SCLP_EVENT{ DeviceClass.unplug } callback
> from qdev_unplug() making this unreachable code,
> so drop it as well.
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>
> ---
>  hw/s390x/event-facility.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Cornelia Huck <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]