[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom v3 07/14] qdev: gpio: Re-impement qdev_conne
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH qom v3 07/14] qdev: gpio: Re-impement qdev_connect_gpio QOM style |
Date: |
Fri, 26 Sep 2014 15:04:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
Il 26/09/2014 07:20, Peter Crosthwaite ha scritto:
> + if (pin) {
> + object_property_add_child(qdev_get_machine(), "non-qdev-gpio[*]",
> + OBJECT(pin), NULL);
> + }
So here is when you're using the "do not abort if not a child" behavior.
It deserves at least a comment, because it's not obvious.
Paolo
- [Qemu-devel] [PATCH qom v3 01/14] qdev: gpio: Don't allow name share between I and O, (continued)
- [Qemu-devel] [PATCH qom v3 01/14] qdev: gpio: Don't allow name share between I and O, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 02/14] qdev: gpio: Register GPIO inputs as child objects, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 03/14] qdev: gpio: Register GPIO outputs as QOM links, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 04/14] qmp: qstring: Handle NULL strings, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 05/14] qom: Allow clearing of a Link property, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 06/14] qom: Demote already-has-a-parent to a regular error, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 07/14] qdev: gpio: Re-impement qdev_connect_gpio QOM style, Peter Crosthwaite, 2014/09/26
- Re: [Qemu-devel] [PATCH qom v3 07/14] qdev: gpio: Re-impement qdev_connect_gpio QOM style,
Paolo Bonzini <=
- [Qemu-devel] [PATCH qom v3 08/14] qdev: gpio: Add API for intercepting a GPIO, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 09/14] qtest/irq: Rework IRQ interception, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 10/14] irq: Remove qemu_irq_intercept_out, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 11/14] qdev: gpio: delete NamedGPIOList::out, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 13/14] qdev: gpio: Define qdev_pass_gpios(), Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 14/14] sysbus: Use TYPE_DEVICE GPIO functionality, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 12/14] qdev: gpio: Remove qdev_init_gpio_out x1 restriction, Peter Crosthwaite, 2014/09/26
- Re: [Qemu-devel] [PATCH qom v3 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs, Paolo Bonzini, 2014/09/26