[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/11] serial: check if backed by a physical serial p
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 08/11] serial: check if backed by a physical serial port at realize time |
Date: |
Fri, 26 Sep 2014 16:38:07 +0200 |
Right now, s->poll_msl may linger at "0" value for an arbitrarily long
time, until serial_update_msl is called for the first time. This is
unnecessary, and will lead to the s->poll_msl field being unnecessarily
migrated.
We can call serial_update_msl immediately at realize time (via
serial_reset) and be done with it. The memory-mapped UART was already
doing that, but not the ISA and PCI variants.
Regarding the delta bits, be consistent with what serial_reset does when
the serial port is not backed by a physical serial port, and always clear
them at reset time.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/char/serial.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/char/serial.c b/hw/char/serial.c
index 847dacc..ebcacdc 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -815,6 +815,9 @@ static void serial_reset(void *opaque)
s->thr_ipending = 0;
s->last_break_enable = 0;
qemu_irq_lower(s->irq);
+
+ serial_update_msl(s);
+ s->msr &= ~UART_MSR_ANY_DELTA;
}
void serial_realize_core(SerialState *s, Error **errp)
@@ -945,7 +948,5 @@ SerialState *serial_mm_init(MemoryRegion *address_space,
memory_region_init_io(&s->io, NULL, &serial_mm_ops[end], s,
"serial", 8 << it_shift);
memory_region_add_subregion(address_space, base, &s->io);
-
- serial_update_msl(s);
return s;
}
--
2.1.0
- [Qemu-devel] [PULL 00/11] KVM (and more) patches for 2014-09-26, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 01/11] pit: fix pit interrupt can't inject into vm after migration, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 02/11] Introduce cpu_clean_all_dirty, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 04/11] kvmclock: Ensure time in migration never goes backward, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 03/11] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 05/11] hw/dma/i8257: Silence phony error message, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 06/11] target-i386: update fp status fix, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 08/11] serial: check if backed by a physical serial port at realize time,
Paolo Bonzini <=
- [Qemu-devel] [PULL 07/11] serial: reset state at startup, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 10/11] po: fix conflict with %.mo rule in rules.mak, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 09/11] kvmvapic: fix migration when VM paused and when not running Windows, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 11/11] kvm/valgrind: don't mark memory as initialized, Paolo Bonzini, 2014/09/26
- Re: [Qemu-devel] [PULL 00/11] KVM (and more) patches for 2014-09-26, Peter Maydell, 2014/09/26