[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/17] accel: Move accel init/allowed code to
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/17] accel: Move accel init/allowed code to separate function |
Date: |
Fri, 26 Sep 2014 17:05:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
Il 29/08/2014 22:31, Eduardo Habkost ha scritto:
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> hw/core/accel.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/hw/core/accel.c b/hw/core/accel.c
> index aeb779a..5817c3c 100644
> --- a/hw/core/accel.c
> +++ b/hw/core/accel.c
> @@ -57,6 +57,17 @@ static AccelClass *accel_find(const char *opt_name)
> return ac;
> }
>
> +static int accel_init(AccelClass *acc, MachineClass *mc)
> +{
> + int ret;
> + *(acc->allowed) = true;
> + ret = acc->init(mc);
> + if (ret < 0) {
> + *(acc->allowed) = false;
> + }
> + return ret;
> +}
> +
> int configure_accelerator(MachineClass *mc)
> {
> const char *p;
> @@ -87,14 +98,12 @@ int configure_accelerator(MachineClass *mc)
> acc->name);
> continue;
> }
> - *(acc->allowed) = true;
> - ret = acc->init(mc);
> + ret = accel_init(acc, mc);
> if (ret < 0) {
> init_failed = true;
> fprintf(stderr, "failed to initialize %s: %s\n",
> acc->name,
> strerror(-ret));
> - *(acc->allowed) = false;
> } else {
> accel_initialised = true;
> }
>
Reviewed-by: Paolo Bonzini <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 12/17] accel: Move accel init/allowed code to separate function,
Paolo Bonzini <=