Re: [Qemu-devel] [PATCH v2 11/17] accel: Remove tcg_available() function

[Paolo Bonzini]

Il 29/08/2014 22:31, Eduardo Habkost ha scritto:
> As the function always return 1, it is not needed anymore.
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  arch_init.c                | 5 -----
>  hw/core/accel.c            | 1 -
>  include/sysemu/arch_init.h | 1 -
>  3 files changed, 7 deletions(-)
> 
> diff --git a/arch_init.c b/arch_init.c
> index 28ece76..4cd21c9 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -1335,11 +1335,6 @@ void cpudef_init(void)
>  #endif
>  }
>  
> -int tcg_available(void)
> -{
> -    return 1;
> -}
> -
>  int kvm_available(void)
>  {
>  #ifdef CONFIG_KVM
> diff --git a/hw/core/accel.c b/hw/core/accel.c
> index 5853551..aeb779a 100644
> --- a/hw/core/accel.c
> +++ b/hw/core/accel.c
> @@ -119,7 +119,6 @@ static void tcg_accel_class_init(ObjectClass *oc, void 
> *data)
>  {
>      AccelClass *ac = ACCEL_CLASS(oc);
>      ac->name = "tcg";
> -    ac->available = tcg_available;
>      ac->init = tcg_init;
>      ac->allowed = &tcg_allowed;
>  }
> diff --git a/include/sysemu/arch_init.h b/include/sysemu/arch_init.h
> index 182d48d..5968837 100644
> --- a/include/sysemu/arch_init.h
> +++ b/include/sysemu/arch_init.h
> @@ -32,7 +32,6 @@ void do_smbios_option(QemuOpts *opts);
>  void ram_mig_init(void);
>  void cpudef_init(void);
>  void audio_init(void);
> -int tcg_available(void);
>  int kvm_available(void);
>  int xen_available(void);
>  
> 

When we will support disabling of TCG, we will move the registration to
translate-all.c so the function will not exist anyway.

Reviewed-by: Paolo Bonzini <address@hidden>

Paolo