[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] ssh: Don't crash if either host or path is n
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] ssh: Don't crash if either host or path is not specified. |
|
Date: |
Mon, 29 Sep 2014 11:20:32 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Sep 29, 2014 at 09:06:22AM +0100, Richard W.M. Jones wrote:
> $ ./qemu-img create -f qcow2 overlay \
> -b 'json: { "file.driver":"ssh",
> "file.host":"localhost",
> "file.host_key_check":"no" }'
> qemu-img: qobject/qdict.c:193: qdict_get_obj: Assertion `obj != ((void *)0)'
> failed.
> Aborted
>
> A similar crash also happens if the file.host field is omitted.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1147343
>
> Bug found and reported by Jun Li.
>
> Signed-off-by: Richard W.M. Jones <address@hidden>
> ---
> block/ssh.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Please CC Kevin Wolf and me on block patches.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpCcsusVRvQW.pgp
Description: PGP signature