Re: [Qemu-devel] [PATCH v2 18/36] qdev: drop hotplug check from bus_add_child()

[Paolo Bonzini]

Il 26/09/2014 11:28, Igor Mammedov ha scritto:
> check is too restrictive and does not allow
> to add childs to just created bus during hotplug
> when the bus is part of composite device.
> 
> Removing check from bus_add_child() doesn't affect
> devices creatable with device_add/del commands since
> they have a similar builtin checks and patch will
> allow to create complex composite devices during
> hotplug.
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  hw/core/qdev.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 0de99b2..fa86843 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -85,10 +85,6 @@ static void bus_add_child(BusState *bus, DeviceState 
> *child)
>      char name[32];
>      BusChild *kid = g_malloc0(sizeof(*kid));
>  
> -    if (qdev_hotplug) {
> -        assert(qbus_is_hotpluggable(bus));
> -    }
> -
>      kid->index = bus->max_index++;
>      kid->child = child;
>      object_ref(OBJECT(kid->child));
> 

Reviewed-by: Paolo Bonzini <address@hidden>