[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target-mips: fix broken MIPS16 and microMIPS
|
From: |
Maciej W. Rozycki |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] target-mips: fix broken MIPS16 and microMIPS |
|
Date: |
Mon, 29 Sep 2014 14:03:53 +0100 |
|
User-agent: |
Alpine 1.10 (DEB 962 2008-03-14) |
On Fri, 1 Aug 2014, Yongbok Kim wrote:
> Ping!
> Patch for v2.1.0
>
> -----Original Message-----
> From: Yongbok Kim
> Sent: 01 July 2014 17:43
> To: address@hidden
> Cc: address@hidden; Leon Alrae; Cristian Cuna; Yongbok Kim
> Subject: [PATCH v2] target-mips: fix broken MIPS16 and microMIPS
>
> Commit 240ce26a broke MIPS16 and microMIPS support as it didn't
> care those branches and jumps don't have delay slot in
> MIPS16 and microMIPS.
>
> This patch introduces a new argument delayslot_size to the
> gen_compute_branch() indicating size of delay slot {0, 2, 4}.
> And the information is used to call handle_delay_slot() forcingly
> when no delay slot is required.
>
> There are some microMIPS branch and jump instructions that requires
> exact size of instruction in the delay slot. For indicating
> these instructions, MIPS_HFLAG_BDS_STRICT flag is introduced.
>
> Those fictional branch opcodes defined to support MIPS16 and
> microMIPS are no longer needed.
>
> Signed-off-by: Yongbok Kim <address@hidden>
> ---
Nice cleanup overall, thanks for doing it.
FWIW,
Maciej