[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/6] Q35: Implement -cdrom/-hda sugar
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/6] Q35: Implement -cdrom/-hda sugar |
Date: |
Tue, 30 Sep 2014 10:02:27 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
John Snow <address@hidden> writes:
> The Q35 board initialization does not currently bother to look
> for any drives added by the various syntactical sugar shorthands
> to be added to the AHCI HBA. These include -hda through -hdd,
> -cdrom, and -drive if=ide shorthands.
>
> An obstacle to having implemented this sooner is debate over
> whether or not to add an additional interface type, and how to
> manage the different units-per-bus mappings of various HBA
> implementations.
>
> This patch series:
> (1) Does not add IF_AHCI, but reuses IF_IDE
> (2) Allows the if_max_devs table to be overridden
> (3) Adds this override to the Q35 board type.
> (4) Finally, adds implementation to Q35 initialization.
General: commit messages' line lengths on the short side (~50 rather
than the customary ~70), but that's better than too long.
I think PATCH 4 could be improved further, but the only issue serious
enough to make me withhold my R-by is the unexplained change from fatal
error to warning there.
Almost there :)
- [Qemu-devel] [PATCH v2 1/6] blockdev: Orphaned drive search, (continued)
- [Qemu-devel] [PATCH v2 1/6] blockdev: Orphaned drive search, John Snow, 2014/09/29
- [Qemu-devel] [PATCH v2 3/6] pc/vl: Add units-per-default-bus property, John Snow, 2014/09/29
- [Qemu-devel] [PATCH v2 2/6] blockdev: Allow overriding if_max_dev property, John Snow, 2014/09/29
- [Qemu-devel] [PATCH v2 4/6] ide: Update ide_drive_get to be HBA agnostic, John Snow, 2014/09/29
- [Qemu-devel] [PATCH v2 6/6] q35/ahci: Pick up -cdrom and -hda options, John Snow, 2014/09/29
- [Qemu-devel] [PATCH v2 5/6] qtest/bios-tables: Correct Q35 command line, John Snow, 2014/09/29
- Re: [Qemu-devel] [PATCH v2 0/6] Q35: Implement -cdrom/-hda sugar,
Markus Armbruster <=