Re: [Qemu-devel] [PATCH v5] pci-hotplug-old: avoid losing error message

[Markus Armbruster]

<address@hidden> writes:

> From: Gonglei <address@hidden>
>
> When scsi_bus_legacy_add_drive() produces an error,
> we will lose the error message. Using qerror_report_err
> to report it because it is an HMP-only command.
>
> Cc: Markus Armbruster <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  v5:
>   using qerror_report_err instead of error_report for an
>   HMP-only command (Paolo)
>  v4:
>   fix typo in the subject (Eric), Thanks.
>  v3:
>   fix some typos/grammar issues (Eric) and add 'R-by' tag
>  v2:
>   using original condition instead of local_err (Markus)

I liked v4 better.  See my reply there for my reasons.