[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message |
|
Date: |
Tue, 30 Sep 2014 10:18:20 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
Il 30/09/2014 10:12, Markus Armbruster ha scritto:
> error_report() is just fine here. qerror_report() is never necessary in
> HMP-only code. It makes a difference only in QMP context, and even
> there it should only be used in code that hasn't been converted to the
> Error API. For an example, see commit b1422f2.
>
> Eventually, qerror.h should just die. I've been chipping away at it
> when I have nothing better to do. Slow progress, better than no
> progress.
>
> Let's commit v4.
Yeah, I've seen now that error_report ends up in monitor_vprintf.
v4 is okay, sorry Gonglei.
Paolo