[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message
|
From: |
Gonglei (Arei) |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message |
|
Date: |
Tue, 30 Sep 2014 08:23:05 +0000 |
> Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error
> message
>
> Il 30/09/2014 10:12, Markus Armbruster ha scritto:
> > error_report() is just fine here. qerror_report() is never necessary in
> > HMP-only code. It makes a difference only in QMP context, and even
> > there it should only be used in code that hasn't been converted to the
> > Error API. For an example, see commit b1422f2.
> >
> > Eventually, qerror.h should just die. I've been chipping away at it
> > when I have nothing better to do. Slow progress, better than no
> > progress.
> >
> > Let's commit v4.
>
> Yeah, I've seen now that error_report ends up in monitor_vprintf.
>
> v4 is okay, sorry Gonglei.
>
> Paolo
I'm fine, I'm a learner in some area. :)
Who can merge this patch? Paolo, can you? Thanks!
Best regards,
-Gonglei