qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyI


From: Gonglei
Subject: Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct
Date: Tue, 30 Sep 2014 22:01:49 +0800

> Subject: Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in
> PropertyInfo struct
> 
> On Tue, Sep 30, 2014 at 03:36:22PM +0200, Paolo Bonzini wrote:
> > Il 30/09/2014 15:33, Michael S. Tsirkin ha scritto:
> > > > >
> > > > The Propertyinfo.name is used to the qdev property's type, please see
> PATCH 4:
> > > >
> > > > -            info->type = g_strdup(prop->info->legacy_name ?:
> prop->info->name);
> > > > +            info->type = g_strdup(prop->info->name);
> > >
> > > I would say this one is more a string than an int.
> >
> > At the QOM level it is an int, even though it secondarily accepts a
> > string in "DD.F" format.
> >
> > Paolo
> 
> That's the only way to specify a function, isn't it?

As far as I can tell, yes.

Best regards,
-Gonglei

> Maybe it's not a good idea to expose the QOM type in this case.
> 
> --
> MST




reply via email to

[Prev in Thread] Current Thread [Next in Thread]