Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

[Michael S. Tsirkin]

On Thu, Oct 02, 2014 at 10:05:38AM +0200, Jan Kiszka wrote:
> On 2014-10-02 10:03, Michael S. Tsirkin wrote:
> > On Thu, Oct 02, 2014 at 09:27:41AM +0200, Jan Kiszka wrote:
> >> On 2014-09-02 17:11, Michael Roth wrote:
> >>> Quoting Markus Armbruster (2014-07-30 06:19:36)
> >>>> Paolo Bonzini <address@hidden> writes:
> >>>>
> >>>>> Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto:
> >>>>>> On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan Kiszka wrote:
> >>>>>>> We used to be able to address both the QEMU and the KVM APIC via 
> >>>>>>> "apic".
> >>>>>>> This doesn't work anymore. So we need to use their parent class to 
> >>>>>>> turn
> >>>>>>> off the vapic on machines that should not expose them.
> >>>>>>>
> >>>>>>> Signed-off-by: Jan Kiszka <address@hidden>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> OK so this is intended for 2.2?
> >>>>
> >>>> If yes, we should cc: qemu-stable.
> >>>
> >>> Ping for stable 2.1.1, freeze is on Wednesday
> >>
> >> Lost track of this: was I supposed to provide anything different, or did
> >> this just fall under the table?
> >>
> >> Jan
> > 
> > Yes, I think Michael expected an ACK for stable.
> > Oh well.
> > Would you like me to apply as is, or to rework this to avoid duplication
> > of string names?
> 
> I don't mind, but I wouldn't refuse if you want to take care of the issue.
> 
> Jan

I've applied as-is for now, thanks.


I think the use of strings in compat machine types
is too fragile, we should have a header with
type names, and reuse it through macros, but
apic is not unique here.

> -- 
> Siemens AG, Corporate Technology, CT RTC ITP SES-DE
> Corporate Competence Center Embedded Linux