qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] libqos: Add malloc generic


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 2/3] libqos: Add malloc generic
Date: Thu, 2 Oct 2014 13:09:42 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Sep 04, 2014 at 06:24:38PM +0200, Marc MarĂ­ wrote:
> This malloc is a basic interface implementation that works for any platform.
> It should be replaced in the future for a real malloc implementation for each
> of the platforms.
> 
> Signed-off-by: Marc MarĂ­ <address@hidden>
> ---
>  tests/libqos/malloc-generic.c |   54 
> +++++++++++++++++++++++++++++++++++++++++
>  tests/libqos/malloc-generic.h |   18 ++++++++++++++
>  2 files changed, 72 insertions(+)
>  create mode 100644 tests/libqos/malloc-generic.c
>  create mode 100644 tests/libqos/malloc-generic.h

malloc-pc.c is the "real malloc implementation" you speak of.  Just
pc_alloc_init_flags() needs to be tweaked for the memory map of a
particular platform.

I'm not sure I see the point of this patch.  Instead we should reuse
malloc-pc.c.

Attachment: pgpRoEH29hVtO.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]