[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] vmdk: Fix integer overflow in offset calcula
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5] vmdk: Fix integer overflow in offset calculation |
Date: |
Thu, 2 Oct 2014 13:51:12 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Sep 23, 2014 at 09:56:21AM +0800, Fam Zheng wrote:
> This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
> allocation).
>
> $ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
> write failed: Invalid argument
>
> Reported-by: Mark Cave-Ayland <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
>
> ---
> v5: Fix group file and output reference. (Max)
> v4: Fix typo in file header: 1014 -> 2014.
> v3: A new case 105 instead of embedding in 005. (Max)
> ---
> block/vmdk.c | 2 +-
> tests/qemu-iotests/105 | 70
> ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/105.out | 21 ++++++++++++++
> tests/qemu-iotests/group | 1 +
> 4 files changed, 93 insertions(+), 1 deletion(-)
> create mode 100755 tests/qemu-iotests/105
> create mode 100644 tests/qemu-iotests/105.out
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpOC3sm5_Bic.pgp
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v5] vmdk: Fix integer overflow in offset calculation,
Stefan Hajnoczi <=