[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/6] blockdev-test: Clean up bogus drive_add argumen
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 3/6] blockdev-test: Clean up bogus drive_add argument |
Date: |
Thu, 2 Oct 2014 16:51:33 +0200 |
The first argument should be a PCI address, which pci-addr=auto isn't.
Doesn't really matter, as drive_add ignores its first argument when
its second argument has if=none. Clean it up anyway.
Signed-off-by: Markus Armbruster <address@hidden>
---
tests/drive_del-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/drive_del-test.c b/tests/drive_del-test.c
index 786f026..67309fd 100644
--- a/tests/drive_del-test.c
+++ b/tests/drive_del-test.c
@@ -83,7 +83,7 @@ static void test_after_failed_device_add(void)
*/
response = qmp("{'execute': 'human-monitor-command',"
" 'arguments': {"
- " 'command-line': 'drive_add pci-addr=auto
if=none,id=drive0'"
+ " 'command-line': 'drive_add 0 if=none,id=drive0'"
"}}");
g_assert(response);
g_assert_cmpstr(qdict_get_try_str(response, "return"), ==, "OK\r\n");
--
1.9.3
- [Qemu-devel] [PATCH 4/6] blockdev-test: Simplify by using g_assert_cmpstr(), (continued)
- [Qemu-devel] [PATCH 4/6] blockdev-test: Simplify by using g_assert_cmpstr(), Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 2/6] blockdev-test: Use single rather than double quotes in QMP, Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 5/6] blockdev-test: Factor out some common code into helpers, Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 6/6] blockdev-test: Test device_del after drive_del, Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 3/6] blockdev-test: Clean up bogus drive_add argument,
Markus Armbruster <=
- [Qemu-devel] [PATCH 1/6] drive_del-test: Merge of qdev-monitor-test, blockdev-test, Markus Armbruster, 2014/10/02
- Re: [Qemu-devel] [PATCH 0/6] Improve drive_del test coverage, Stefan Hajnoczi, 2014/10/04