Re: [Qemu-devel] [PATCH 1/3] libqos: Remove PCI assumptions in virtio driver

[Marc Marí]

El Thu, 2 Oct 2014 13:02:25 +0100
Stefan Hajnoczi <address@hidden> escribió:
> On Thu, Sep 04, 2014 at 06:24:37PM +0200, Marc Marí wrote:
> > @@ -60,25 +60,25 @@ static void
> > qvirtio_pci_assign_device(QVirtioDevice *d, void *data) *vpcidev =
> > (QVirtioPCIDevice *)d; }
> >  
> > -static uint8_t qvirtio_pci_config_readb(QVirtioDevice *d, void
> > *addr) +static uint8_t qvirtio_pci_config_readb(QVirtioDevice *d,
> > uint64_t addr) {
> >      QVirtioPCIDevice *dev = (QVirtioPCIDevice *)d;
> > -    return qpci_io_readb(dev->pdev, addr);
> > +    return qpci_io_readb(dev->pdev, (void *)addr);
> 
> You do not need casts in C for void* to any pointer type or any
> pointer type to void*.  Please drop them.

addr is of type uint64_t, not a pointer. So if there's no cast it will
fail to compile (expected ‘void *’ but argument is of type ‘uint64_t’)

Marc