qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] gdb: provide the name of the architecture in th


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] gdb: provide the name of the architecture in the target.xml
Date: Mon, 6 Oct 2014 17:57:29 +0100

On 6 October 2014 16:08, Cornelia Huck <address@hidden> wrote:
> On Tue, 30 Sep 2014 17:23:47 +0200
> Jens Freimann <address@hidden> wrote:
>
>> From: David Hildenbrand <address@hidden>
>>
>> This patch provides the name of the architecture in the target.xml if 
>> available.
>>
>> This allows the remote gdb to detect the target architecture on its own - so
>> there is no need to specify it manually (e.g. if gdb is started without a
>> binary) using "set arch *arch_name*".
>>
>> The name of the architecture has been added to all archs that provide a
>> target.xml (by supplying a gdb_core_xml_file) and have a unique architecture
>> name in gdb's feature xml files.
>>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> Acked-by: Cornelia Huck <address@hidden>
>> Acked-by: Christian Borntraeger <address@hidden>
>> Signed-off-by: Jens Freimann <address@hidden>
>> Reviewed-by: Andreas Färber <address@hidden>
>> Cc: Andrzej Zaborowski <address@hidden>
>> Cc: Peter Maydell <address@hidden>
>> Cc: Vassili Karpov (malc) <address@hidden>
>> CC: Edgar Iglesias <address@hidden>
>> CC: Richard Henderson <address@hidden>
>> ---
>>  gdbstub.c                   | 19 ++++++++++++-------
>>  include/qom/cpu.h           |  2 ++
>>  target-arm/cpu64.c          |  1 +
>>  target-ppc/translate_init.c |  2 ++
>>  target-s390x/cpu.c          |  1 +
>>  5 files changed, 18 insertions(+), 7 deletions(-)
>>
> I will send this with the next pile of s390x updates, unless someone on
> cc: has any objections.

I'm still hoping for an answer about why this is setting
the name for 64 bit ARM and not 32 bit ARM, and whether
there are any cases which need to actually be able to set
the architecture name in a more complicated name than
simply a string. I raised those in the last lot of review
and there doesn't seem to have been any answer.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]