qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 32/47] postcopy: ram_enable_notify to switch


From: Dr. David Alan Gilbert
Subject: Re: [Qemu-devel] [PATCH v4 32/47] postcopy: ram_enable_notify to switch on userfault
Date: Mon, 6 Oct 2014 20:00:52 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

* Paolo Bonzini (address@hidden) wrote:
> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
> > +static int postcopy_ram_sensitise_area(const char *block_name, void 
> > *host_addr,
> > +                                       ram_addr_t offset, ram_addr_t 
> > length,
> > +                                       void *opaque)
> 
> Weird name, and I'm not referring to the British -ise. :)
> 
> Perhaps ram_block_enable_userfault or ram_block_enable_notify?  It helps
> clarity to limit the use of the "postcopy_ram_" prefix for static function.

Yep, that's fair enough; I'll make it ram_block_enable_notify.

Dave

> Paolo
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK



reply via email to

[Prev in Thread] Current Thread [Next in Thread]