[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] snapshot: Reset err to NULL to avoid double fre
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] snapshot: Reset err to NULL to avoid double free |
|
Date: |
Tue, 07 Oct 2014 08:52:48 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Copying stable and maintainers.
Chris Spiegel <address@hidden> writes:
> If an error occurs in bdrv_snapshot_delete_by_id_or_name(), "err" is
> freed. If "err" is not set to NULL before calling
> bdrv_snapshot_delete_by_id_or_name() again, it will not be updated on
> error, and will be freed again.
>
> This can be triggered by starting a VM with at least two drives and then
> attempting to delete a non-existent snapshot.
>
> Signed-off-by: Chris Spiegel <address@hidden>
Broken in commit a89d89d.
With the above sentence added to the commit message:
Reviewed-by: Markus Armbruster <address@hidden>
I checked the commit and the file for similar bugs, didn't find any.