[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops |
Date: |
Tue, 07 Oct 2014 12:12:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
Il 07/10/2014 10:58, Dr. David Alan Gilbert ha scritto:
>
>>> > > + if (exitcode & LOADVM_EXITCODE_QUITPARENT) {
>>> > > + DPRINTF("loadvm_handlers_state_main: End of loop with
>>> > > QUITPARENT");
>>> > > + exitcode &= ~LOADVM_EXITCODE_QUITPARENT;
>>> > > + exitcode &= LOADVM_EXITCODE_QUITLOOP;
>> >
>> > Either you want |=, or the first &= is useless.
> Ooh nicely spotted; yes that should be |= - now I need to figure out why this
> didn't break things.
>
> The idea is we have:
> 1 outer loadvm_state loop
> 2 receives packaged command
> 3 inner_loadvm_state loop
> 4 receives handle_listen
> 5 < QUITPARENT
> 6 < QUITLOOP
> 7 < QUITLOOP
> 8 exits
>
> so QUITPARENT causes it's parent to exit, and to do that
> the inner loop transforms QUITPARENT into QUITLOOP as it's
> exit.
Yes, that was my understanding as well.
We have only two nested loops, but if we had three, should it be
QUIT_PARENT or QUIT_ALL?
Paolo
- Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path, (continued)
[Qemu-devel] [PATCH v4 15/47] Return path: Send responses from destination to source, Dr. David Alan Gilbert (git), 2014/10/03
[Qemu-devel] [PATCH v4 17/47] qemu_loadvm errors and debug, Dr. David Alan Gilbert (git), 2014/10/03
[Qemu-devel] [PATCH v4 18/47] ram_debug_dump_bitmap: Dump a migration bitmap as text, Dr. David Alan Gilbert (git), 2014/10/03
[Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops, Dr. David Alan Gilbert (git), 2014/10/03
[Qemu-devel] [PATCH v4 20/47] Add migration-capability boolean for postcopy-ram., Dr. David Alan Gilbert (git), 2014/10/03
[Qemu-devel] [PATCH v4 21/47] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages., Dr. David Alan Gilbert (git), 2014/10/03
[Qemu-devel] [PATCH v4 22/47] QEMU_VM_CMD_PACKAGED: Send a packaged chunk of migration stream, Dr. David Alan Gilbert (git), 2014/10/03
[Qemu-devel] [PATCH v4 23/47] migrate_init: Call from savevm, Dr. David Alan Gilbert (git), 2014/10/03
[Qemu-devel] [PATCH v4 24/47] Allow savevm handlers to state whether they could go into postcopy, Dr. David Alan Gilbert (git), 2014/10/03
[Qemu-devel] [PATCH v4 25/47] postcopy: OS support test, Dr. David Alan Gilbert (git), 2014/10/03